Skip to content

add rule id to docs #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Conversation

jrobison-sb
Copy link
Contributor

  • I noticed a deprecation warning of Deprecation warning : Use 'id' (AC_AWS_0058) instead of 'reference_id' (AWS.RDS.DataSecurity.High.0414) and wanted to fix it in my config file, but then noticed that those ID's (AC_AWS_0058) aren't documented anywhere other than within the json of each rule. So I figured I would propose adding those ID's to the docs.
  • I now see that maybe this repo isn't even the source of truth for the docs anymore? But the https://github.com/accurics/runterrascan.io repo doesn't seem to have any automation to rebuild these, or does it? Anyway, I'm happy to add this if possible but would appreciate guidance if I'm doing it in the wrong place.
  • And this also fixes a bug in docs/policies/document_policies.py where it crashed when trying to iterate over files in pkg/policies/opa/rego when it was expecting to iterate over directories.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #1136 (7685329) into master (14a634b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1136   +/-   ##
=======================================
  Coverage   79.09%   79.09%           
=======================================
  Files         248      248           
  Lines        6907     6907           
=======================================
  Hits         5463     5463           
  Misses       1113     1113           
  Partials      331      331           

@cesar-rodriguez
Copy link
Contributor

Thanks @jrobison-sb !

@sangam14 we need an easier/better way to sync these with runterrascan.io

@cesar-rodriguez cesar-rodriguez merged commit 9780e13 into tenable:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants