Feature/s3 policy update #1153
Merged
Feature/s3 policy update #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1153 +/- ##
=======================================
Coverage 78.31% 78.31%
=======================================
Files 271 271
Lines 7449 7449
=======================================
Hits 5834 5834
Misses 1280 1280
Partials 335 335 |
harkirat22
suggested changes
Feb 17, 2022
harkirat22
reviewed
Feb 17, 2022
pkg/policies/opa/rego/aws/aws_s3_bucket/noS3BucketSseRules.rego
Outdated
Show resolved
Hide resolved
harkirat22
reviewed
Feb 17, 2022
harkirat22
reviewed
Feb 18, 2022
| checkSSE(sseConfig) | ||
| } | ||
|
|
||
| checkSSE(sseConfig) { |
There was a problem hiding this comment.
this function is not requires. If resource is declared S3 bucket will have the default s3 (AWS) managed sse is enabled.
|
Kudos, SonarCloud Quality Gate passed!
|
harkirat22
approved these changes
Feb 18, 2022
gaurav-gogia
added a commit
that referenced
this pull request
Feb 18, 2022
This reverts commit f1acad7.
This was referenced Feb 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update sse and s3 versioning policies to accommodate v4 changes in aws terraform provider
creating this pr for issue #1152