Include DirScanErrors info in SARIF file #1398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1398 +/- ##
==========================================
+ Coverage 77.27% 77.30% +0.02%
==========================================
Files 279 279
Lines 7856 7866 +10
==========================================
+ Hits 6071 6081 +10
Misses 1426 1426
Partials 359 359
|
|
@gaurav-gogia thanks for the review. |
|
@nasir-rabbani Let me know if looks good to merge, thanks. |
|
Pinging, it would be great if this improvement was merged soon |
|
note: The |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Update: Test passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, currently the DirScanErrors messages are not recorded in the SARIF file,
this information could be useful for the SARIF file consumer.
This pr added this missing info so that the consumer of the SARIF file can have this info and act as necessary.
These messages are considered warning so the change is adding a new node to the json which should not break existing user.
We have updated the go-sarif sdk to the v2, which is necessary for this change.
And I see v2 have much more SARIF properties support than v1 which is great changes.
The json properties order changed slightly so the text cases are fixed accordingly.
Fixed a issue that multierr.Append() does not assign the result so it is missing from the object for later usage.
golang.org/x/exp/typeparamsis removed by tidy mod.