Skip to content

1061: generate multi-architecture (amd64, arm64) docker image #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 22, 2023
Merged

1061: generate multi-architecture (amd64, arm64) docker image #1568

merged 10 commits into from
Aug 22, 2023

Conversation

denisa
Copy link
Contributor

@denisa denisa commented May 27, 2023

see https://github.com/denisa/terrascan/pkgs/container/terrascan

Note that the docker buildx build must build & push the image in a single operation, so I had to add some logic to the docker-build.sh script to support:

  • building locally an image for the local computer architecture only
  • building a multi-architecture image on CI

This PR also partially resolves warnings related to the deprecation of node.js 12; I did not attempt to update codecov/codecov-action@v1 as the most recent (v3) version is not compatible and I would not be able to test it.

@denisa denisa requested review from a team and bkizer-tenable as code owners May 27, 2023 22:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@denisa
Copy link
Contributor Author

denisa commented Jun 2, 2023

@tenable/terrascan-maintainers … any comments?

@denisa
Copy link
Contributor Author

denisa commented Aug 6, 2023

@bkizer-tenable: any comment? Can this be merged?

@denisa
Copy link
Contributor Author

denisa commented Aug 11, 2023

@Rchanger , @srokade-tenable ?

@Rchanger
Copy link
Contributor

@Rchanger , @srokade-tenable ?

sorry for late reply let me review it once and will get back,thank you for your efforts.

denisa added 2 commits August 16, 2023 07:58
because this project publishes to dockerhub, not a a GH package
because this project publishes to dockerhub, not a a GH package
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #1568 (dfc9a30) into master (659310c) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1568   +/-   ##
=======================================
  Coverage   78.49%   78.49%           
=======================================
  Files         280      280           
  Lines        7906     7906           
=======================================
  Hits         6206     6206           
  Misses       1329     1329           
  Partials      371      371           

@denisa
Copy link
Contributor Author

denisa commented Aug 22, 2023

@Rchanger thank you for the approval.
How will this be merged? I can’t do it myself.

@Rchanger
Copy link
Contributor

@Rchanger thank you for the approval. How will this be merged? I can’t do it myself.
I'll merge.

@Rchanger Rchanger merged commit 9e99f08 into tenable:master Aug 22, 2023
@denisa denisa deleted the dna/1061 branch August 22, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants