-
Notifications
You must be signed in to change notification settings - Fork 518
1061: generate multi-architecture (amd64, arm64) docker image #1568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…actions to use Node.js 16: actions/checkout@v2, actions/setup-go@v1 Skipping codecov/codecov-action@v1 ...
Kudos, SonarCloud Quality Gate passed!
|
@tenable/terrascan-maintainers … any comments? |
@bkizer-tenable: any comment? Can this be merged? |
sorry for late reply let me review it once and will get back,thank you for your efforts. |
because this project publishes to dockerhub, not a a GH package
because this project publishes to dockerhub, not a a GH package
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1568 +/- ##
=======================================
Coverage 78.49% 78.49%
=======================================
Files 280 280
Lines 7906 7906
=======================================
Hits 6206 6206
Misses 1329 1329
Partials 371 371 |
@Rchanger thank you for the approval. |
|
see https://github.com/denisa/terrascan/pkgs/container/terrascan
Note that the
docker buildx build
must build & push the image in a single operation, so I had to add some logic to the docker-build.sh script to support:This PR also partially resolves warnings related to the deprecation of node.js 12; I did not attempt to update
codecov/codecov-action@v1
as the most recent (v3) version is not compatible and I would not be able to test it.