set console mode on windows so colors render

[acc-jon]

No description provided.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codecov]

Codecov Report

Merging #427 (e6af151) into master (e3bb0bd) will increase coverage by 2.70%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
+ Coverage   63.50%   66.21%   +2.70%     
==========================================
  Files          76       85       +9     
  Lines        1677     1915     +238     
==========================================
+ Hits         1065     1268     +203     
- Misses        520      535      +15     
- Partials       92      112      +20     

Impacted Files	Coverage Δ
pkg/iac-providers/register.go	66.66% <0.00%> (-33.34%)	⬇️
pkg/utils/yaml.go	71.92% <0.00%> (-1.41%)	⬇️
pkg/runtime/validate.go	81.08% <0.00%> (ø)
pkg/policy/cloud-providers.go	100.00% <0.00%> (ø)
pkg/iac-providers/providers.go	100.00% <0.00%> (ø)
pkg/iac-providers/terraform.go	100.00% <0.00%> (ø)
pkg/iac-providers/kubernetes.go	100.00% <0.00%> (ø)
pkg/iac-providers/kubernetes/v1/normalize.go	74.46% <0.00%> (ø)
pkg/iac-providers/kustomize/v3/load-dir.go	73.07% <0.00%> (ø)
pkg/policy/helm.go	100.00% <0.00%> (ø)
... and 12 more

[williepaul]

Hey Jon,

One suggestion--can we detect if virtual terminal processing console mode is disabled, and either switch to no-color automatically, issue a warning, or both?

[acc-jon]

Hi Willie, the PreRun func for scanCmd in cli/scan.go will disable colored output mode if the terminal is not a tty.

This code just ensures that Windows users will be able to see colored output. The default mode is disabled, probably for historical reasons that are no longer relevant.

Note that Terrascan uses third-party packages like zap that also expect a color-capable terminal. If we wanted to disable colors then we would need to figure out how/if those could be forced to a non-color mode.