Add policy AC-K8-NS-SE-M-0188 for CVE-2020-8554 #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
=======================================
Coverage 66.21% 66.21%
=======================================
Files 85 85
Lines 1915 1915
=======================================
Hits 1268 1268
Misses 535 535
Partials 112 112 |
williepaul
reviewed
Dec 10, 2020
pkg/policies/opa/rego/k8s/kubernetes_service/cve_2020_8554/ensurePrivateIP.rego
Outdated
Show resolved
Hide resolved
williepaul
reviewed
Dec 10, 2020
| {{.prefix}}{{.name}}{{.suffix}}[service.id] { | ||
| service := input.{{.resource_type}}[_] | ||
| service.config.kind == "Service" | ||
| type_check(service.config.spec) |
There was a problem hiding this comment.
IMO we should keep our checks as simple as possible. it looks like you're just trying to do the following:
service.config.spec.type == "ClusterIP"
not service.config.spec.type
service.config.spec.externalIPs
Do we also need a check for service.config.spec.clusterIPs?
There was a problem hiding this comment.
Service type may or may not be set. If its set then I want to if its ClusterIP
|
Kudos, SonarCloud Quality Gate passed!
|
williepaul
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.