Adds support for using Terraform modules cached locally #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #940 +/- ##
==========================================
- Coverage 79.10% 78.93% -0.17%
==========================================
Files 220 221 +1
Lines 5359 5413 +54
==========================================
+ Hits 4239 4273 +34
- Misses 866 880 +14
- Partials 254 260 +6
|
Rchanger
force-pushed
the
sr_support_for_using_tf_cache
branch
from
ec41505 to
6e79069
Compare
Fixes typo
- changed interface method signature to accept map parameter so that we can pass any no of flag to implementer without changing method signature. - moved the non recursive flag to map to achieve uniformity - In terraform used switch for flag identification so that in future new flag or option provided just need to add another case rather than if/else
updated all links .
We doSupport TLS certificate/key in existing secrets
Adds pre-commit integration for Terrascan Co-authored-by: mihirhasan <[email protected]>
cesar-rodriguez
changed the title
cesar-rodriguez
suggested changes
Aug 2, 2021
There was a problem hiding this comment.
I'm trying to test this feature, but seems like it's not deducting the module directory correctly. I'm using Terraform v0.15.5 with this main.tf file:
module "vault" {
source = "hashicorp/vault/aws"
version = "0.16.0"
ssh_key_name = ""
create_dns_entry = false
}
When I run:
terrascan scan -i terraform --use-terraform-cache -l debug
I get this error message and it also downloads the modules instead of using the local cache
2021-08-01T22:52:56.103-0400 error utils/dir.go:49 directory /Users/myusername/programming/vault/.terraform/modules/vault/.terraform/modules does not exist.
2021-08-01T22:52:56.103-0400 debug downloader/getter.go:49 downloading "github.com/hashicorp/terraform-aws-consul.git?ref=v0.8.0" to "/var/folders/2g/9lkfm6ld2lv350svwr15fdgc0000gn/T/n1ukaa"
The cached modules are actually located at:
/Users/myusername/programming/vault/.terraform/modules
- modified code to make scan directory non recursively when --use-terraform-cache is used. - modified scan command flag description and docs accordingly.
cesar-rodriguez
previously approved these changes
Aug 4, 2021
cesar-rodriguez
previously approved these changes
Aug 4, 2021
cesar-rodriguez
previously approved these changes
Aug 4, 2021
cesar-rodriguez
changed the title
cesar-rodriguez
changed the title
- modified docker LoadIacDir and LoadIacFile method to accept map parameter - registered docker as cloud provider so that docker policies will be used from '.terrascan' folder
|
Kudos, SonarCloud Quality Gate passed!
|
patilpankaj212
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add: support for using the terraform init cache for remote modules rather than downloading it again. It will try to use the remote module from terraform cache if --use-terraform-cache flag is set and if the module is not found in cache it will be downloaded
Usage
Closes #936