Skip to content

Adds additional policies for dockerfile #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 24, 2021
Merged

Conversation

pavniii
Copy link
Contributor

@pavniii pavniii commented Aug 17, 2021

No description provided.

Pavni Parghi added 6 commits August 11, 2021 18:01
1.exposeport
2.image version not using latest
3.use of apk upgrade
4.yum update
1. runusingcd
2.Changing Default Shell Using SHELL Command
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #996 (7f7ee1a) into master (b42be70) will not change coverage.
The diff coverage is n/a.

❗ Current head 7f7ee1a differs from pull request most recent head 733a1b0. Consider uploading reports for the commit 733a1b0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #996   +/-   ##
=======================================
  Coverage   78.58%   78.58%           
=======================================
  Files         224      224           
  Lines        5650     5650           
=======================================
  Hits         4440     4440           
  Misses        930      930           
  Partials      280      280           
Impacted Files Coverage Δ
pkg/policy/types.go 100.00% <0.00%> (ø)
pkg/iac-providers/kustomize/v3/types.go
pkg/iac-providers/kustomize/v3/load-dir.go
pkg/iac-providers/kustomize/v3/load-file.go
pkg/iac-providers/kustomize/v4/types.go 100.00% <0.00%> (ø)
pkg/iac-providers/kustomize/v4/load-dir.go 71.69% <0.00%> (ø)
pkg/iac-providers/kustomize/v4/load-file.go 100.00% <0.00%> (ø)

@cesar-rodriguez cesar-rodriguez changed the title adding new docker policies Adds additional policies for dockerfile Aug 18, 2021
@cesar-rodriguez cesar-rodriguez added the policy Issue concerning policy maintainers. label Aug 20, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

package accurics

{{.prefix}}{{.name}}{{.suffix}}[dockerFrom]{
dockerFrom := input.docker_from[_]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HEALTHCHECK is in itself a command, so check in docker_dockerfile

{{.prefix}}{{.name}}{{.suffix}}[dockerFrom.id]{
dockerFrom := input.docker_from[_]
config := dockerFrom.config
not contains(config, ":latest")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be contains

@@ -0,0 +1,6 @@
package accurics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check this in dockerfile as input.

@@ -1,7 +1,7 @@
package accurics

{{.prefix}}{{.name}}{{.suffix}}[dockerFrom]{
dockerFrom := input.docker_from[_]
dockerFrom := input.docker_dockerfile[_]
config := dockerFrom.config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config is an array for dockerfile as input

@harkirat22 harkirat22 merged commit d1a11f3 into tenable:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
policy Issue concerning policy maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants