perf: improve the rename performance. #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyang733
force-pushed
the
perf-improve_rename_performance
branch
from
0a8510c to
2806d10
Compare
Signed-off-by: Yang Yu <[email protected]>
yuyang733
force-pushed
the
perf-improve_rename_performance
branch
from
2806d10 to
afbdde5
Compare
vintmd
reviewed
Mar 21, 2025
| } else { | ||
| result = this.copyFile(srcPath, dstPath); | ||
| result = this.copyFile(srcPath, destPath); |
|
|
||
| Pair<CosNFileStatus, CosNFileStatus> renameFileStatusPair = new Pair<>(); | ||
|
|
||
| // Hadoop FileSystem Specification: if not exists(FS, src) : raise FileNotFoundException |
There was a problem hiding this comment.
If the source file src does not exist, FileNotFoundException should be raised.
HDFS fails without raising an exception; rename() merely returns false.
false -> notfound 兼容性要测下
| if (dstFileStatus.isFile()) { | ||
| LOG.debug("File: {} already exists.", dstFileStatus.getPath()); | ||
| return false; | ||
| throw new FileAlreadyExistsException(dstPath.toString()); |
There was a problem hiding this comment.
Renaming a file atop an existing file is specified as failing, raising an exception.
HDFS : The rename fails, no exception is raised. Instead the method call simply returns false.
兼容性？
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { |
| // For symlink types, the Hadoop file system specification does not provide clear instructions, | ||
| // I tested the soft connection in the POSIX file system, and the same behavior is also true. | ||
| return true; | ||
| } | ||
| return false; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.