This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Fix bug in batchGathering
#767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if `batchGathering` was operating upon a batch of data, it would get stuck during the final reshape, due to using the wrong input tensor shape. This change fixes that and includes a test case that caught the bug before the fix was applied. ``` Test Case '-[TensorFlowTests.BasicOperatorTests testBatchGatheringAcrossBatch]' started. Fatal error: Input to reshape is a tensor with 6 values, but the requested shape has 3: file /Users/saeta/src/swift-apis/Sources/TensorFlow/Bindings/EagerExecution.swift, line 301 Exited with signal code 4 ```
|
PTAL @eaplatanios |
|
Note: this unblocks tensorflow/swift-models#344 |
|
Sorry @saeta didn't manage to take a look into this earlier because these days are kind of crazy. The fix looks good to me! |
|
hehe, no worries, thanks @eaplatanios !! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if
batchGatheringwas operating upon a batch of data, it would getstuck during the final reshape, due to using the wrong input tensor shape. This
change fixes that and includes a test case that caught the bug before the fix was
applied.