replaced deprecated substring #395
Conversation
|
#389 @texasmichelle I saw this issue after making PR. Sorry if I have duplicated your work |
|
The issue was there so that someone could fix it :) Thank you for this submission @SumanSudhir !! |
| rows[rows.count - 1] = String( | ||
| rows[rows.count - 1].substring(to: rows[rows.count - 1].index(rows[rows.count - 1].endIndex, offsetBy: -2))) | ||
| // Removing the last '"\n' | ||
| rows[rows.count - 1] = String(rows[rows.count - 1].suffix(2)) |
There was a problem hiding this comment.
This command does in fact remove the substring-related warning, but it removes everything except the last two characters. We're looking for a command that keeps everything except the trailing newline and quotation mark.
| @@ -1,799 +1,1094 @@ | |||
| { | |||
| "cells": [ | |||
There was a problem hiding this comment.
This diff makes it hard to see what has changed, which I believe should only be a single cell. I suggest doing a text replace, then running separately to ensure it's correct. @sgugger do you have a better process for making notebook changes?
There was a problem hiding this comment.
Ideally, just making the change in the cell is better to avoid large diffs. Otherwise, reviewNB is great to see the diff on notebooks.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
LGTM.
I realize it's not part of this change, but I beg, fer the love a' Mike, in future when any of us embeds Swift in Python strings, we use raw triple-' strings
r'''
public func readCSV(in file: URL) -> [String] {
let rawText = try! String(contentsOf: file, encoding: .utf8)
var rows = rawText.components(separatedBy: "\"\n\"")
…etc…
'''.splitlines(keepends=True)
Replaced
substring(to:)here as it is showing warning: 'substring(to:)' is deprecated: Please use String slicing subscript with a 'partial range upto' operator.