Introduce tf-per-run-steps-selector #471
Conversation
The PR curves plugin had used a special tf-pr-curve-steps-selector component for letting the user select a single step to apply across all tags for a given run. This change moves that tf-pr-curve-steps-selector component into the components directory and renames it to tf-global-steps-selector. Some documentation was added to several properties of the component. Also removed the tf-color-scale import from tf-pr-curve-dashboard. The dashboard does not need it.
chihuahua
force-pushed
the
chihuahua-generalize-slider
branch
from
d785e97 to
be5c6fc
Compare
|
This doesn't sound like what folks are asking for in #469. It isn't a "global step slider for images," it's one slider per run. |
chihuahua
changed the title
|
True. How about |
|
I mean, yeah, that's a better name, but take a step back: this isn't what users want. (No one has requested this; people have requested a single global slider.) Why do you want to implement it? |
|
A single global slider seems sub-optimal (but a potential option - It is more convenient.) because runs can differ by a lot in steps, whereas steps are often the same within a run. What do you think? |
|
Asked in #469. |
|
Closing in favor of a global step slider (see my latest comment in #469) , although I still prefer that we unify and recommend 1 component for step selection in the future. That gets us code reuse (for plugin developers) and UI consistency (for end users). Really though, what I really want right now is just to try something reasonably justified and see how users react. |
The PR curves plugin had used a special tf-pr-curve-steps-selector
component for letting the user select a single step to apply across all
tags for a given run. Other plugins could also benefit from that
functionality. See #469.
This change moves that tf-pr-curve-steps-selector component into the
components directory and renames it to tf-per-run-steps-selector. Some
documentation was added to several properties of the component.
Also removed the tf-color-scale import from tf-pr-curve-dashboard. The
dashboard does not need it.
The PR curves dashboard WAI.