Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for Staging Distribution #130

Merged

Conversation

ogugu9
Copy link
Contributor

@ogugu9 ogugu9 commented Feb 21, 2024

Description

  • Support for staging distribution feature.
    • add staging variable
    • add continuous_deployment_policy_id variable

Closes #131

Motivation and Context

In order to use staging distribution feature, we must set staging = true to the staging distribution and specify continuous_deployment_policy_id for the primary distribution.
So I added these variables.

Breaking Changes

No breaking changes.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request
❯ pre-commit run -a 
Terraform fmt............................................................Passed
Terraform wrapper with for_each in module................................Passed
Terraform validate.......................................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
check for merge conflicts................................................Passed
fix end of files.........................................................Passed

@antonbabenko antonbabenko changed the title feat: Support for Staging Distribution feat: Added support for Staging Distribution Mar 1, 2024
@antonbabenko antonbabenko merged commit 601df49 into terraform-aws-modules:master Mar 1, 2024
9 checks passed
antonbabenko pushed a commit that referenced this pull request Mar 1, 2024
## [3.3.0](v3.2.2...v3.3.0) (2024-03-01)

### Features

* Added support for Staging Distribution ([#130](#130)) ([601df49](601df49))
@antonbabenko
Copy link
Member

This PR is included in version 3.3.0 🎉

Copy link

github-actions bot commented Apr 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Staging Distributon
2 participants