feat: Search for Windows or Linux AMIs only if they are needed

[barryib]

PR o'clock

Description

This will add support to search for Windows (or Linux) AMI only if they are needed.

• Resolves Prevent creation of windows ami datasource when we don't define windows worker nodes #1100
• Resolves module returns "query returned no results" when using a non existent cluster_version #1141
• Resolves Upgrade cluster version is not supported #1246
• Resolves EKS version 1.19 unable to find ami #1247
• Resolves how to disable windows support #582

Checklist

• CI tests are passing
• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[dbirks]

Nice, thank you! Just ran a plan with this branch, and it doesn't error out, even though there's not a 1.20 windows ami yet. 🎉

[barryib]

v16.1.0 is released.

[brettcave]

This PR introduced a bug that breaks if Windows nodes are used:

06e9078#diff-2fdb488192d2afd49fb090fcc8bd32fd3af72bcb789420915e78d6406ef9e2e4R19

worker_has_linux_ami   = length([for x in concat(var.worker_groups, var.worker_groups_launch_template) : x if lookup(x, "platform", "linux") == "linux"]) > 0
  worker_has_windows_ami = length([for x in concat(var.worker_groups, var.worker_groups_launch_template) : x if lookup(x, "platform", "linux") == "windows"]) > 0

[barryib]

This PR introduced a bug that breaks if Windows nodes are used

@brettcave What do you mean by "it brakes" ? Can you please share your error and configuration ?

[brettcave]

This PR introduced a bug that breaks if Windows nodes are used

@brettcave What do you mean by "it brakes" ? Can you please share your error and configuration ?

#1410

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.