-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow interface_type to be specified in worker_groups_launch_template #1439
Conversation
…e passed into worker_groups_launch_template.
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This PR has been automatically closed because it has not had recent activity since being marked as stale. |
Please keep this open until this change (or something similar) is applied. There is currently no other way to specify the interface type. |
@paulbsch could you solve a conflicts? |
Should be good now, just let me know if I need to do anything else @daroga0002 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and is working fine 🚀
@paulbsch thank you for contribution
@antonbabenko this also can be merged
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
…e passed into worker_groups_launch_template.
PR o'clock
Description
This really simple PR allows setting the "interface_type" for launch templates. This is needed to use EFA interfaces. The change doesn't appear to need and README.md updates.
Checklist