fix: Allow interface_type to be specified in network_interfaces #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e passed into worker_groups_launch_template.
Signed-off-by: Kenneth Hill <[email protected]>
Signed-off-by: Kenneth Hill <[email protected]>
|
Closes #1880 |
|
thank you for the PR @kenhill - we'll need to add/update an example somewhere to test/verify the changes |
3 tasks
|
This issue has been resolved in version 18.18.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for "interface_type" in network_interfaces.
Motivation and Context
This is needed to use Amazon EFA interfaces and is restoring functionality added in v17.21.0+ (#1439 ) which is missing from both EKS managed and self managed node groups. Note, the aws API does not support passing security groups from both network_interfaces and vpc_security_group_ids at the same time.
Breaking Changes
N/A
How Has This Been Tested?
examples/*projectsThis change is currently being used to deploy JarviceXE (https://github.com/nimbix/jarvice-helm/tree/tf-aws-eks-module-18-eks-managed) to enable support for workloads that utilize Amazon EFA interface. JarviceXE was previously deployed using v17.20.0 which included interface_type support from #1439