fix: Add conditional variable to allow users to opt out of tagging cluster primary security group #2034
+12
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uster primary security group
antonbabenko
pushed a commit
that referenced
this pull request
Apr 21, 2022
### [18.20.5](v18.20.4...v18.20.5) (2022-04-21) ### Bug Fixes * Add conditional variable to allow users to opt out of tagging cluster primary security group ([#2034](#2034)) ([51e4182](51e4182))
|
This PR is included in version 18.20.5 🎉 |
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Apr 26, 2022
…uster primary security group (terraform-aws-modules#2034)
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Apr 26, 2022
### [18.20.5](terraform-aws-modules/terraform-aws-eks@v18.20.4...v18.20.5) (2022-04-21) ### Bug Fixes * Add conditional variable to allow users to opt out of tagging cluster primary security group ([terraform-aws-modules#2034](terraform-aws-modules#2034)) ([51e4182](terraform-aws-modules@51e4182))
it-without-politics
pushed a commit
to it-without-politics/terraform-aws-eks
that referenced
this pull request
May 23, 2022
…uster primary security group (terraform-aws-modules#2034)
it-without-politics
pushed a commit
to it-without-politics/terraform-aws-eks
that referenced
this pull request
May 23, 2022
### [18.20.5](terraform-aws-modules/terraform-aws-eks@v18.20.4...v18.20.5) (2022-04-21) ### Bug Fixes * Add conditional variable to allow users to opt out of tagging cluster primary security group ([terraform-aws-modules#2034](terraform-aws-modules#2034)) ([51e4182](terraform-aws-modules@51e4182))
baibailiha
added a commit
to baibailiha/terraform-aws-eks
that referenced
this pull request
Sep 13, 2022
### [18.20.5](terraform-aws-modules/terraform-aws-eks@v18.20.4...v18.20.5) (2022-04-21) ### Bug Fixes * Add conditional variable to allow users to opt out of tagging cluster primary security group ([#2034](terraform-aws-modules/terraform-aws-eks#2034)) ([e7affe9](terraform-aws-modules/terraform-aws-eks@e7affe9))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
disk_sizewhich has been shown incorrectly in various examples and come up in prior issues causing confusiondisk_sizeis only used when using the default launch template created by the EKS managed node group service. This module defaults to creating a custom launch template since this provide a more feature complete experience for users and enables missing features like instance tagging.Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request