self-managed-node-group output "image_id" will only show the default ami, and not any var.ami_id provided

[bushong1]

Description

When you create a self-managed-node-group and provide it a non-default ami_id, the instances will be launched correctly, but the output from the submodule will indicate that the image_id applied was the default eks ami_id derived from the data source.

Source References:

• self-managed-node-group output block
• Code that sets the node images in the launch template

If you provide a custom AMI ID, the output will show the incorrect data.

• ✋ I have searched the open/closed issues and my issue is not listed.

⚠️ Note

Before you submit an issue, please perform the following first:

1. Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
2. Re-initialize the project root to pull down modules: terraform init
3. Re-attempt your terraform plan or apply and check if the issue still persists

Versions

• Module version [Required]: 18.29.0

• Terraform version: 1.2.8

• Provider version(s):
  • registry.terraform.io/hashicorp/aws v4.28.0

Reproduction Code [Required]

Steps to reproduce the behavior:

Provide self_managed_node_groups with a non-default ami_id

Expected behavior

output of self_managed_node_groups should show instances have the provided image_id

Actual behavior

output self_managed_node_groups instead shows instances have the default image_id

[bryantbiggs]

correct - we only output the AMI ID that the module uses if one is not provided since it is not readily known to users. if you are passing in a custom AMI ID then that ID is readily known to you already

[bushong1]

@bryantbiggs it doesn't cost anything to return the correct value. Why not make them the same?

[bushong1]

@bryantbiggs can we re-open this; I have a PR for it in #2239

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.