Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: add multiple selectors on the creation of fargate profile #1158

Closed

Conversation

Lena-nfb
Copy link
Contributor

@Lena-nfb Lena-nfb commented Dec 22, 2020

PR o'clock

Description

Add selectors dynamically; update example

Resolves #1367

Checklist

@Lena-nfb Lena-nfb changed the title add multiple selectors on the creation of fargate profile improvement: add multiple selectors on the creation of fargate profile Dec 22, 2020
@barryib
Copy link
Member

barryib commented Dec 23, 2020

@Lena-nfb can you please update your branch and resolve conflict.

@Lena-nfb
Copy link
Contributor Author

branch has been updated and conflicts have been resolved.

@Lena-nfb
Copy link
Contributor Author

Lena-nfb commented Jan 4, 2021

Hi, do you require any further updates on this P/R? thanks very much.

@stale
Copy link

stale bot commented May 5, 2021

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
To track this PR (even if closed), please open a corresponding issue if one does not already exist.

@stale stale bot added the stale label May 5, 2021
@barryib barryib self-assigned this May 19, 2021
@stale stale bot removed the stale label May 19, 2021
@barryib
Copy link
Member

barryib commented May 19, 2021

Hey @Lena-nfb sorry for the long silence. Are you still working on this ? Can you please rebase your branch from master and resolve conflicts ?

@barryib
Copy link
Member

barryib commented May 20, 2021

Closing this in favor of #1378

@barryib barryib closed this May 20, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to add multiple selectors to fargate profile
5 participants