fix: add create_launch_template to node group pet marker #1349
Conversation
- When using this option alone, the nodegroup re-create in place blows up as the pet name is node changed. By adding this to the pet marker, it ensures that a new pet name is generated if this variable is flipped
jack1902
changed the title
jack1902
changed the title
|
@barryib appreciate you are probably very busy, but any chance this could get a review? |
|
@barryib ok, assuming that PR gets merged soon then i'm happy for this to be closed This feature missing was a PITA to resolve when i needed to cycle a full node group, which resulted in terraform erroring out as the nodegroup already existed. We went from no Launch Template to having one which didn't change the pet-name but resulted in a re-creation because of #1348 meant our entire mesh network died due to nodes having different security groups based on launch template |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
PR o'clock
relates to: #1348
Description
When changing
create_launch_templateONLY on my node_groups, it caused terraform to blow up because it couldn't create a new node group with the same name. This took me by surprise.Checklist