feat: Add support for autoscaling group AMI override #1501
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
Resolves #1498
Allow users to specify different AMIs based on the instance type ( more details in #1498 )
Since aws has introduced eks support for arm instances the module should also support the creation of asg with mixed instance type (arm64, x64).
The suggested way to implement this feature is to create multiple
launchtemplates
and overriding the default launch template with a specific one related to the instance type.Example
This change introduce more complexity in the
aws_launch_template
creation since we now have to create multipleaws_launch_template
for the sameaws_autoscaling_group
ifoverride_instance_ami
is specified.In order to avoid the duplication of
aws_launch_template.workers_launch_template
the resource is not created using afor_each
which creates a launch template for every node group * n. of specified overrides,Ideas to reduce the complexity of the features are welcome.
Checklist