feat: Support offline bootstrap of Windows nodes

[jaroslav-fedor-swi]

PR o'clock

Description

In case you need to spin nodes in environment, that does not have egress to internet windows nodes does not connect to cluster. The reason behind that is that Start-EKSBootstrap.ps1 which is baked in windows EKS AMI is executed with minimal set of parameters which then requires egress to eks.<region>.amazonaws.com. This endpoint does not support private link and does not come with managed prefix list. The only way to make the Boostrap script offline is to pass additional arguments - private EKS endpoint and Cluster CA.

Checklist

• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[daroga0002]

could you add working example of EKS with Windows nodes to https://github.com/terraform-aws-modules/terraform-aws-eks/tree/master/examples ?

[bryantbiggs]

this looks like an area where we just make a generic variable and its up to users to provide whatever arguments they want for input rather than building out this massive string of input options

[stale]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
To track this PR (even if closed), please open a corresponding issue if one does not already exist.

[daroga0002]

@jaroslav-fedor-swi could you add provide here some EKS configuration with working windows workers or node groups?

[jaroslav-fedor-swi]

@daroga0002 I added example of windows_launch_templates.

[daroga0002]

@jaroslav-fedor-swi I have run example but seems it is not working as EKS is created, instances are also created but they had not joined to EKS cluster

[daroga0002]

I think I require to run procedure to enable windows support over EKS.

I will try that approach

[daroga0002]

@jaroslav-fedor-swi 2 comments to address before merging

[daroga0002]

Suggested change

	This is EKS example using workers launch template with worker groups feature.
	This is EKS example using workers launch template with Windows worker groups feature. Additionally it create managed group with Linux nodes to satisfy generic EKS object placement (like Coredns).
	After creating EKS cluster following procedure must be executed https://docs.aws.amazon.com/eks/latest/userguide/windows-support.html#macos-and-linux to allow Windows nodes to join cluster.

[daroga0002]

Suggested change

	]
	]
	node_groups = {
	linux = {
	desired_capacity = 1
	max_capacity = 10
	min_capacity = 1
	instance_types = ["t3.large"]
	}
	}

[daroga0002]

@jaroslav-fedor-swi can you commit those two suggestions into your branch?

[github-actions]

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

[github-actions]

This PR was automatically closed because of stale in 10 days

[antonbabenko]

This issue has been resolved in version 18.0.0 🎉

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.