fix: unable to have more than one fargate profile

[ehrenkret]

PR o'clock

Description

Resolves issue #1245

local.fargate_profiles_expanded is always empty when local.create_eks is false so the ternary operator here can be omitted.

local.create_eks is defined as var.create_eks && length(var.fargate_profiles) > 0

local.fargate_profiles_expanded is defined as { for k, v in var.fargate_profiles : k => merge( v, { tags = merge(var.tags, lookup(v, "tags", {})) }, ) if var.create_eks }

If var.create_eks is false, then local.fargate_profiles_expanded will have all entries filtered out by the conditional in the for expression.
If var.fargate_profiles is length 0, then local.fargate_profiles_expanded will have no entries to iterate over in the for expression.

Checklist

• Add semantics prefix to your PR or Commits (at least one of your commit groups)
• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[daroga0002]

terraform-aws-eks/modules/fargate/locals.tf

Lines 6 to 9 in 85ca4ca

	fargate_profiles_expanded = { for k, v in var.fargate_profiles : k => merge(
	v,
	{ tags = merge(var.tags, lookup(v, "tags", {})) },
	) if var.create_eks }

[antonbabenko]

Fixed in #1583 (9885ac0)

[antonbabenko]

v17.19.0 has been just released with this fix.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.