Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Supporting update_config in EKS managed node groups #1560

Merged
merged 6 commits into from
Sep 3, 2021
Merged

feat: Supporting update_config in EKS managed node groups #1560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d7b94e7
feat: Supporting update_config in EKS managed node groups (#1554)
Sep 2, 2021
1c828f9
Merge branch 'master' into master
marianobilli Sep 2, 2021
a8128f9
feat: Supporting update_config in EKS managed node groups (#1554)
Sep 2, 2021
7c36a29
Merge branch 'master' of github.com:marianobilli/terraform-aws-eks in…
Sep 2, 2021
472f6b8
chore: Fixed docs and simplified code a bit
antonbabenko Sep 3, 2021
0988c70
Merge remote-tracking branch 'origin/master' into marianobilli/master
antonbabenko Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/managed_node_groups/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ module "eks" {
effect = "NO_SCHEDULE"
}
]
update_config = {
max_unavailable_percentage = 50 # or set `max_unavailable`
}
}
}

Expand Down
2 changes: 2 additions & 0 deletions modules/node_groups/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ The role ARN specified in `var.default_iam_role_arn` will be used by default. In
| launch\_template_version | The version of the LT to use | string | none |
| max\_capacity | Max number of workers | number | `var.workers_group_defaults[asg_max_size]` |
| min\_capacity | Min number of workers | number | `var.workers_group_defaults[asg_min_size]` |
| update_config.max\_unavailable\_percentage | Max percentage of unavailable nodes during update. (e.g. 25, 50, etc) | number | `null` if `update_config.max_unavailable` is set |
| update_config.max\_unavailable | Max number of unavailable nodes during update | number | `null` if `update_config.max_unavailable_percentage` is set |
| name | Name of the node group. If you don't really need this, we recommend you to use `name_prefix` instead. | string | Will use the autogenerate name prefix |
| name_prefix | Name prefix of the node group | string | Auto generated |
| pre_userdata | userdata to pre-append to the default userdata. Require `create_launch_template` to be `true`| string | "" |
Expand Down
9 changes: 9 additions & 0 deletions modules/node_groups/node_groups.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,15 @@ resource "aws_eks_node_group" "workers" {
}
}

dynamic "update_config" {
for_each = try(each.value.update_config.max_unavailable_percentage > 0, each.value.update_config.max_unavailable > 0, false) ? [true] : []

content {
max_unavailable_percentage = try(each.value.update_config.max_unavailable_percentage, null)
max_unavailable = try(each.value.update_config.max_unavailable, null)
}
}

timeouts {
create = lookup(each.value["timeouts"], "create", null)
update = lookup(each.value["timeouts"], "update", null)
Expand Down