feat: Add add metadata options to managed node groups launch template

[xr0n1ck]

PR o'clock

Description

Please explain the changes you made here and link to any relevant issues.

Checklist

• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[antonbabenko]

Let's generate metadata_options using dynamic and create it only if one of 3 inputs are present. Exactly as here - https://github.com/terraform-aws-modules/terraform-aws-autoscaling/blob/master/main.tf#L92-L99

[daroga0002]

looks that it is duplicating #1485

[daroga0002]

looks that it is duplicating #1485

[xr0n1ck]

@antonbabenko
Should I make changes to #1485
or can I create separate pr with dynamic metadata_options?

[antonbabenko]

@xr0n1ck If you can verify it and apply the changes to that PR, it would be great.

[xr0n1ck]

@antonbabenko
As far as I have no write permissions to that repo, I can create pr to that branch and wait to approval.
It will be easier and faster to create new one, since dynamic metadata little bit different

[antonbabenko]

I understand, let's make a PR based on that one into this repository that will close #1485

[maxbrunet]

Hello! I have rebased #1485

[bryantbiggs]

hi @maxbrunet / @xr0n1ck - whichever PR we go with, can we just copy what we have for the autoscaling group module https://github.com/terraform-aws-modules/terraform-aws-autoscaling/blob/d4b7da041ef781604726953234b5bcd494cc5908/main.tf#L92-L99

you should be able to copy that block, and its variable and paste them in your PRs

[maxbrunet]

@bryantbiggs I copied what was already done in this module, I was thinking to be consistent with that:

terraform-aws-eks/workers_launch_template.tf

Lines 385 to 401 in c2bd137

	metadata_options {
	http_endpoint = lookup(
	var.worker_groups_launch_template[count.index],
	"metadata_http_endpoint",
	local.workers_group_defaults["metadata_http_endpoint"],
	)
	http_tokens = lookup(
	var.worker_groups_launch_template[count.index],
	"metadata_http_tokens",
	local.workers_group_defaults["metadata_http_tokens"],
	)
	http_put_response_hop_limit = lookup(
	var.worker_groups_launch_template[count.index],
	"metadata_http_put_response_hop_limit",
	local.workers_group_defaults["metadata_http_put_response_hop_limit"],
	)
	}

terraform-aws-eks/workers.tf

Lines 268 to 284 in c2bd137

	metadata_options {
	http_endpoint = lookup(
	var.worker_groups[count.index],
	"metadata_http_endpoint",
	local.workers_group_defaults["metadata_http_endpoint"],
	)
	http_tokens = lookup(
	var.worker_groups[count.index],
	"metadata_http_tokens",
	local.workers_group_defaults["metadata_http_tokens"],
	)
	http_put_response_hop_limit = lookup(
	var.worker_groups[count.index],
	"metadata_http_put_response_hop_limit",
	local.workers_group_defaults["metadata_http_put_response_hop_limit"],
	)
	}

Also in the autoscaling module you shared, defaults being null adds to the inconsistency, and this errors if http_endpoint is not specified:

http_endpoint               = lookup(metadata_options.value, "http_endpoint", null)

http_endpoint must be one of enabled or disabled.

[bryantbiggs]

I'm confused, what you said is inconsistent is what you have in your PR https://github.com/terraform-aws-modules/terraform-aws-eks/pull/1485/files#diff-1044253a991537ca26fb2e4d8ffd2689492a98061b0c1cada5531a90516fae71R79

[maxbrunet]

I apply the defaults here https://github.com/terraform-aws-modules/terraform-aws-eks/pull/1485/files#diff-98193ca5efaaf91be09ba7fc2c847ee1d2df56aa4e9d3691b7fa4e5fffc318edR29-R31

So in code, it is consistent with how the node_groups module applies defaults, and the behaviour is consistent with the self-managed workers

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.