feat: Add Timeout to aws_autoscaling_group - based on #1552 #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filintod
changed the title
csschwe
reviewed
Sep 8, 2021
| @@ -95,6 +95,7 @@ locals { | |||
| additional_ebs_volumes = [] # A list of additional volumes to be attached to the instances on this Auto Scaling group. Each volume should be an object with the following: block_device_name (required), volume_size, volume_type, iops, encrypted, kms_key_id (only on launch-template), delete_on_termination. Optional values are grabbed from root volume or from defaults | |||
| additional_instance_store_volumes = [] # A list of additional instance store (local disk) volumes to be attached to the instances on this Auto Scaling group. Each volume should be an object with the following: block_device_name (required), virtual_name. | |||
| warm_pool = null # If this block is configured, add a Warm Pool to the specified Auto Scaling group. | |||
| timeouts = {} # A map of timeouts for create/update/delete operations | |||
There was a problem hiding this comment.
should this be something like
timeouts = var.timeouts
There was a problem hiding this comment.
only asking because #1552 created a timeouts variable in variables.rb
There was a problem hiding this comment.
yeah, I did closed this and open this other one #1566, I did not reuse that variable but probably can add it as last default value
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
Autoscaling groups timeout is not exposed and sometimes the deletion of an ASG can take more than the default 10m. This is based on top of PR #1552 to reuse the timeout variables
Checklist