Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: removing authors section in readme #1692

Closed
wants to merge 1 commit into from
Closed

Docs: removing authors section in readme #1692

wants to merge 1 commit into from

Conversation

brandonjbjelland
Copy link
Contributor

@brandonjbjelland brandonjbjelland commented Nov 12, 2021 •
edited
Loading

PR o'clock

Description

This is a simple change to the readme, removing the gratuitous Author's section. A few reasons -

  1. The contributors tab tells the whole story for anyone curious about authorship.
  2. All contributors are valued and valuable; some were earlier than others, a handful have gone an extra mile in the module's success. No need for special mention, in my opinion.
  3. My last name and username have changed - an adjustment was needed here anyway and I think this is the best move.

Checklist

@brandonjbjelland
Docs: removing authors section in readme
bfea10f 
A few reasons -
1. The contributors tab tells the whole story for anyone curious about authorship,
2. All contributors are valued; no need to hold any individuals up as heroes.
3. My last name and username have changed - an adjustment was needed here anyway
and I think this is the correct move.
@brandonjbjelland
Copy link
Contributor Author

@barryib or @max-rocket-internet - I don't imagine either of you are against this change, but also wouldn't oppose either of you wanting to keep your name in the credits. Chime in if you can't imagine a world without your name as a part of the project's public face 😉

@brandonjbjelland brandonjbjelland marked this pull request as ready for review November 12, 2021 07:48
@antonbabenko
Copy link
Member

Hi Brandon! Great to see you back :)

I agree with the proposed changes. Let's wait a few days for Thierno and Max to say something before the merge.

@bryantbiggs bryantbiggs mentioned this pull request Dec 7, 2021
Merged
1 task
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 13, 2021
@daroga0002 daroga0002 removed the stale label Dec 13, 2021
@antonbabenko
Copy link
Member

This issue has been resolved in version 18.0.0 🎉

@brandonjbjelland brandonjbjelland deleted the fix/remove-authors-readme-section branch January 17, 2022 19:37
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandonjbjelland @antonbabenko @daroga0002