-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability for tagging AWS-generated ASGs when using managed node groups #1705
Conversation
…sing managed node groups
* Modify logic for asg managed node asg tagging for not crashing when the resource does not exist yet
* Remove forgotten logic from previous attempts
* Change logic to define asg tags by having to declare them in a list of dictionaries. This allows to be granular with the propagate_at_launch parameter.
* Iterate on over node_groups variable, otherwise it breaks as it does not wait for the node_groups_expanded variable * Add conditional to loop in order to prevent error for being empty object when node_groups is removed/not used
This issue has been resolved in version 18.0.0 🎉 |
@antonbabenko any doc for it? seems still not working in version 18.0.6. When I use the var |
@weixianearmap Please see the code in |
@antonbabenko Sorry, I can't find any examples which has asg_tags demo in master branch. I don't think this pr has been merged. That's why I made the comment here. |
This PR was not merged because the same functionality was introduced in #1680. You can search for |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Motivation and Context
Breaking Changes
None as the module behaves the same when not using this functionality.
How Has This Been Tested?
The following scenarios have been tested over my personal AWS account: