Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added action to validate PR title #1715

Merged
merged 1 commit into from
Dec 12, 2021
Merged

Conversation

antonbabenko
Copy link
Member

No description provided.

@antonbabenko
Copy link
Member Author

@bryantbiggs Semantic PR was too simple and often misleading.

The one I am adding here is checking the PR title and printing the reason for the failure. Let me know what do you think about this (check it in action in another existing PR after it is rebased because this check will be using configuration from the master branch).

@antonbabenko antonbabenko merged commit 3002be5 into master Dec 12, 2021
@antonbabenko antonbabenko deleted the feat-pr-title branch December 12, 2021 20:49
@antonbabenko
Copy link
Member Author

Apparently "BREAKING CHANGE" is really breaking everything. I will look into this somewhere else in a separate repo.

bryantbiggs pushed a commit to bryantbiggs/terraform-aws-eks that referenced this pull request Dec 13, 2021
bryantbiggs pushed a commit to bryantbiggs/terraform-aws-eks that referenced this pull request Dec 13, 2021
@bryantbiggs
Copy link
Member

this looks great. we can also add one additional step that will show us what the next release version is slated to be by adding

	- name: Release check
        uses: cycjimmy/semantic-release-action@v2
        with:
          dry_run: true
          semantic_version: 18.0.0
          extra_plugins: |
            @semantic-release/[email protected]
            @semantic-release/[email protected]
        env:
          GITHUB_TOKEN: ${{ secrets.SEMANTIC_RELEASE_TOKEN }}

its essentially the same release step we already use, but by adding the dry_run: true it will not make any release changes and instead just output what the next version and changelog entry would be for the PR - Ref https://github.com/cycjimmy/semantic-release-action#dry_run

@antonbabenko
Copy link
Member Author

Good, I will update the EKS module.

dry_run does not help so much, because the release version will depend on the description of the PR during the merge. If it matches r/BREAKING CHANGE[s]*/g then it will be a major release independently of a type (feat, fix, etc...).

@antonbabenko
Copy link
Member Author

This PR is included in version 18.0.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants