-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Added action to validate PR title #1715
Conversation
@bryantbiggs Semantic PR was too simple and often misleading. The one I am adding here is checking the PR title and printing the reason for the failure. Let me know what do you think about this (check it in action in another existing PR after it is rebased because this check will be using configuration from the |
Apparently "BREAKING CHANGE" is really breaking everything. I will look into this somewhere else in a separate repo. |
this looks great. we can also add one additional step that will show us what the next release version is slated to be by adding - name: Release check
uses: cycjimmy/semantic-release-action@v2
with:
dry_run: true
semantic_version: 18.0.0
extra_plugins: |
@semantic-release/[email protected]
@semantic-release/[email protected]
env:
GITHUB_TOKEN: ${{ secrets.SEMANTIC_RELEASE_TOKEN }} its essentially the same release step we already use, but by adding the |
Good, I will update the EKS module.
|
This PR is included in version 18.0.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
No description provided.