Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set default cluster sg description eq 17.24 #1754

Closed
wants to merge 1 commit into from
Closed

fix: Set default cluster sg description eq 17.24 #1754

wants to merge 1 commit into from

Conversation

martijnvdp
Copy link
Contributor

@martijnvdp martijnvdp commented Jan 8, 2022

Description

Set the default value of the cluster security group description eq to the default value of 17.24

Motivation and Context

a change in the description of the cluster security group forces recreation of the security group as well as the eks cluster
as a change of the cluster security group triggers the replacement of the eks cluster
#1744

Breaking Changes

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@bryantbiggs
Copy link
Member

bryantbiggs commented Jan 8, 2022

This is already a variable so users are free to add in the period if desired. Descriptions are not complete, grammatically correct sentences and so periods are not useful here. This was introduced at a breaking change so we are not trying to maintain the legacy compatibility

@martijnvdp martijnvdp closed this Jan 8, 2022
@martijnvdp martijnvdp deleted the fix-security-group-description branch January 8, 2022 14:46
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants