Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add additional port for metrics-server to recommended rules #2353

Merged
merged 3 commits into from
Dec 18, 2022
Merged

feat: Add additional port for metrics-server to recommended rules #2353

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba3e83d
feat: Add additional port for `metrics-server` to recommended rules
bryantbiggs Dec 18, 2022
4de1ee8
Merge branch 'master' into feat/security-group-ports
bryantbiggs Dec 18, 2022
0bebd07
Merge branch 'master' into feat/security-group-ports
bryantbiggs Dec 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions node_groups.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,16 @@ locals {
type = "ingress"
self = true
}
# metrics-server
ingress_cluster_8443_webhook = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bryantbiggs 8443 is typo in the SG name!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gosh dangit - thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2354 should resolve - thanks for catching

description = "Cluster API to node 4443/tcp webhook"
protocol = "tcp"
from_port = 4443
to_port = 4443
type = "ingress"
source_cluster_security_group = true
}
# Karpenter
ingress_cluster_8443_webhook = {
description = "Cluster API to node 8443/tcp webhook"
protocol = "tcp"
Expand All @@ -123,6 +133,7 @@ locals {
type = "ingress"
source_cluster_security_group = true
}
# ALB controller, NGINX
ingress_cluster_9443_webhook = {
description = "Cluster API to node 9443/tcp webhook"
protocol = "tcp"
Expand Down