Unable to fire event on document

[arvigeus]

• react-testing-library version: 5.3.0
• react version: 1.6.6.3
• node version: 8.11.3
• yarn version: 1.12.3

Relevant code or config:

fireEvent.keyDown(document.body, {
  key: "Escape",
  keyCode: 27,
  which: 27
});

What happened:

TypeError: Cannot read property 'defaultView' of null

Suggested solution:

https://github.com/kentcdodds/dom-testing-library/blob/master/src/events.js#L324
Should handle document and window elements (possibly in more places)

[kentcdodds]

Hmmm.... Can you dig deeper because document.body.ownerDocument.defaultView is window:

[alexkrolick]

Not able to reproduce this error - see https://github.com/alexkrolick/repro-document-fire-event/blob/master/src/__tests__/index.test.js

Please provide a minimal reproduction in Codepen or a repo if you can come up with one

It seems possible that this error is due to something else, such as the node being queried being undefined/null

import {fireEvent} from 'react-testing-library'
import React from 'react'


it('fireEvent on document.body should not error', () => {
  fireEvent.keyDown(document.body, {
    key: "Escape",
    keyCode: 27,
    which: 27
  })
})

[abe4mvp]

I am getting this same issue but when im trying to fire an event on document.
fireEvent.keyDown(document, { key: 'ArrowRight'});

also confirmed that
document.ownerDocument is null in the browser

[kentcdodds]

Hey @abe4mvp,

I think that it would be reasonable to change this:

https://github.com/kentcdodds/dom-testing-library/blob/ab29a47386394fee16db700db8cfd5a6ac03c33e/src/events.js#L332

to this:

// if the node does not have an owner document, then it probably _is_ the owner document
const window = (node.ownerDocument || node).defaultView

If you would be willing to make a pull request for that (including a test) then we can merge it and you should be good to go :)

[kentcdodds]

🎉 This issue has been resolved in version 3.17.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀