Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship ES5-compatible bundles #160

Closed
benelliott opened this issue Nov 22, 2018 · 7 comments
Closed

Ship ES5-compatible bundles #160

benelliott opened this issue Nov 22, 2018 · 7 comments
Labels

Comments

@benelliott
Copy link
Contributor

Describe the feature you'd like:

Hi, would you be open to shipping Babel-transpiled ES5 bundles of this library? We are trying to use it over at https://www.github.com/netbasal/spectator but have trouble with IE11 compatibility because of the use of arrow functions in the current UMD bundles.

Suggested implementation:

Configure Babel to support IE11.

Describe alternatives you've considered:

n/a

Teachability, Documentation, Adoption, Migration Strategy:

n/a

@NetanelBasal
Copy link

+1

@kentcdodds
Copy link
Member

Dang it. It looks like some of our dependencies are not compiling themselves. That's pretty annoying. We'll need to figure out how to configure babel to compile node_modules.

This change will need to happen in kcd-scripts. Would you be willing to look into what must be done (probably here) to make that happen?

@NetanelBasal
Copy link

Thanks for the quick response. I guess it means that in general, the library doesn't support IE11.

Do we know which one is the problematic package?

We'll need to figure out how to configure babel to compile node_modules

Remove the exclude?

@benelliott
Copy link
Contributor Author

It looks like these arrow functions are coming from pretty-format, which does ship its own build-es5 module. Maybe if that was specifically loaded instead you wouldn't have to worry about reconfiguring Babel to compile your dependencies?

@kentcdodds
Copy link
Member

Alrighty, this has been fixed! Big thanks to @fobbyal in kentcdodds/kcd-scripts#72

@kentcdodds
Copy link
Member

🎉 This issue has been resolved in version 3.12.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@NetanelBasal
Copy link

Awesome, thanks! Will test it soon and let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants