fix: support babel.config.js #72
Conversation
|
I am not very clear on what you mean.
|
|
I think it actually should just take an update to the rollup config to remove the |
fobbyal
force-pushed
the
support-babel.config.js
branch
from
6c01921 to
825444b
Compare
|
i amended my commit. I do have one question though. Does this mean the build will get a performance hit since babel will try to compile everything? (Sorry i am no babel expert) |
| @@ -115,7 +115,8 @@ const output = [ | |||
| }, | |||
| ] | |||
|
|
|||
| const useBuiltinConfig = !hasFile('.babelrc') && !hasFile('.babelrc.js') && !hasPkgProp('babel') | |||
There was a problem hiding this comment.
Could you update this to allow for the babel.config.js as well?
There was a problem hiding this comment.
oh sorry, I didn't catch that. I am not really a rollback user exactly. I am copying kcd-scripts to make something that feels more natural to me. Thanks for all the effort you put into the community!!!
1. added additional !hasFile logic to recognize babel.config.js in babel script 2. added additional !hasFile logic to reconize babel.config.js in rollup script 3. removed the exclude reference to node_modules in rollup script so depdencies can also be compiled by babel
fobbyal
force-pushed
the
support-babel.config.js
branch
from
825444b to
0a46371
Compare
|
🎉 This PR is included in version 0.46.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What: Added logic to recognize babel.config.js as a source of babel config
Why: Latest babel documentation recommends babel.config.js (stating that babel itself uses this method). https://babeljs.io/docs/en/configuration
How: By adding additional !hasFile logic to the babel.js file
Checklist: