Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matcher import path is broken in get-queries-for-element typings file #42

Closed
kamalgill opened this issue May 18, 2018 · 1 comment
Closed

Comments

@kamalgill
Copy link
Contributor

The Matcher import in typings/get-queries-for-element.d.ts is incorrect.

  • dom-testing-library version: 2.3.1
  • react version: 16.3.1
  • node version: 8.11.1
  • npm (or yarn) version: 6.0.1

Relevant code or config:

The current (incorrect) code is:

import {Matcher} from 'matches'

The correct import is as follows:

import {Matcher} from './matches'

What you did:

Attempt to call ReactTesting.renderIntoDocument(...) in a foo.test.tsx file fails.
Unfortunately the code is in a private GitHub repo that can't be shared here.

What happened:

TypeScript compilation of the app fails and returns the following error message:

node_modules/dom-testing-library/typings/get-queries-for-element.d.ts
(1,23): Cannot find module 'matches'.
@kentcdodds
Copy link
Member

🎉 This issue has been resolved in version 2.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

alexkrolick pushed a commit to alexkrolick/dom-testing-library that referenced this issue Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants