Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kcd-scripts to 13.0.0 #1209

Merged
merged 2 commits into from
Jan 29, 2023
Merged

Bump kcd-scripts to 13.0.0 #1209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb46850
Bump kcd-scripts to 13.0.0
eps1lon Jan 29, 2023
1f2b661
Fix Jest warnings
eps1lon Jan 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@
"jest-in-case": "^1.0.2",
"jest-snapshot-serializer-ansi": "^1.0.0",
"jest-watch-select-projects": "^2.0.0",
"jsdom": "19.0.0",
"kcd-scripts": "^12.3.0",
"jsdom": "20.0.0",
"kcd-scripts": "^13.0.0",
"typescript": "^4.1.2"
},
"eslintConfig": {
Expand Down
10 changes: 5 additions & 5 deletions src/__tests__/suggestions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,8 +612,8 @@ test('should suggest hidden option if element is not in the accessibility tree',
suggestion.toString()

expect(console.warn.mock.calls).toMatchInlineSnapshot(`
Array [
Array [
[
[
Element is inaccessible. This means that the element and all its children are invisible to screen readers.
If you are using the aria-hidden prop, make sure this is the right choice for your case.
,
Expand Down Expand Up @@ -649,9 +649,9 @@ test('should find label text using the aria-labelledby', () => {
warning: '',
},
`
Object {
queryArgs: Array [
Object {},
{
queryArgs: [
{},
],
queryMethod: getByLabelText,
queryName: LabelText,
Expand Down
11 changes: 9 additions & 2 deletions tests/jest.config.dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
const path = require('path')
const baseConfig = require('kcd-scripts/jest')
const {
// global config options that would trigger warnings in project configs
collectCoverageFrom,
watchPlugins,
...baseConfig
} = require('kcd-scripts/jest')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kentcdodds Would it make sense to provide kcd-scripts/jest-global and kcd-scripts/jest-project directly so that consumers of kcd-scripts don't have to manually cherry-pick?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine for me. Happy to merge a PR for that.


module.exports = {
const projectConfig = {
...baseConfig,
rootDir: path.join(__dirname, '..'),
displayName: 'dom',
Expand All @@ -12,3 +17,5 @@ module.exports = {
],
testEnvironment: 'jest-environment-jsdom',
}

module.exports = projectConfig
11 changes: 9 additions & 2 deletions tests/jest.config.node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
const path = require('path')
const baseConfig = require('kcd-scripts/jest')
const {
// global config options that would trigger warnings in project configs
collectCoverageFrom,
watchPlugins,
...baseConfig
} = require('kcd-scripts/jest')

module.exports = {
const projectConfig = {
...baseConfig,
rootDir: path.join(__dirname, '..'),
displayName: 'node',
Expand All @@ -13,3 +18,5 @@ module.exports = {
],
testMatch: ['**/__node_tests__/**.js'],
}

module.exports = projectConfig