FireEvent on Window #165
Merged
FireEvent on Window #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 3.13.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi @VadimBrodsky, I don't know if this PR was supposed to fix this, but at the moment I'm having an error when doing this: fireEvent.mouseMove(window, { clientX: 20, clientY: 50 })Console throws: It works fine when using This is using |
|
Hmmm... Could you open a PR with a failing test? Thanks! |
|
Hey @kentcdodds here is a csb link with a failing test: Does that help? |
|
Got it. I'll have a fix shortly. |
kentcdodds
pushed a commit
that referenced
this pull request
Apr 17, 2019
|
A fix will be released in a minute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Change the typings for
fireEventto accept Window in addition to DOM Elements.Why:
Some events such
postMessageare not fired on a DOM element but rather on Window.How:
Checklist: