-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose pretty-dom utility #25
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4eea14f
Expose pretty-dom utility
gnapse 9c98d6e
Allow users of prettyDOM to set max length
gnapse ff1e40e
Remove logDOM
gnapse cc96516
Add tests for prettyDOM
gnapse 87e2614
Add yarn-error.log to .gitignore
gnapse 4b150b3
Add documencation for prettyDOM
gnapse 30615c0
Update pretty-dom.js
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`it prints out the given DOM element tree 1`] = ` | ||
"[36m<div>[39m | ||
[36m<div>[39m | ||
[0mHello World![0m | ||
[36m</div>[39m | ||
[36m</div>[39m" | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import {prettyDOM} from '../pretty-dom' | ||
import {render} from './helpers/test-utils' | ||
|
||
test('it prints out the given DOM element tree', () => { | ||
const {container} = render('<div>Hello World!</div>') | ||
expect(prettyDOM(container)).toMatchSnapshot() | ||
}) | ||
|
||
test('it supports truncating the output length', () => { | ||
const {container} = render('<div>Hello World!</div>') | ||
expect(prettyDOM(container, 5)).toMatch(/\.\.\./) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import prettyFormat from 'pretty-format' | ||
|
||
const {DOMElement, DOMCollection} = prettyFormat.plugins | ||
|
||
function prettyDOM(htmlElement, maxLength = undefined) { | ||
const debugContent = prettyFormat(htmlElement, { | ||
plugins: [DOMElement, DOMCollection], | ||
printFunctionName: false, | ||
highlight: true, | ||
}) | ||
return maxLength !== undefined && htmlElement.outerHTML.length > maxLength | ||
? `${debugContent.slice(0, maxLength)}...` | ||
: debugContent | ||
} | ||
|
||
export {prettyDOM} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need the
= undefined
because that's functionally equivalent to what the value ofmaxLength
would be anyway :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, I just like to be more explicit in the declaration that the argument is not expected, to anyone that passes by and read the code. Guess flow or typescript would be clearer for that purpose but I have yet to learn to use one of them, it's on my list ;)