Added explicit error message for Promises passed to getWindowFromNode #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2a42a49:
|
Codecov Report
@@ Coverage Diff @@
## master #646 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 565 574 +9
Branches 141 145 +4
=========================================
+ Hits 565 574 +9
Continue to review full report at Codecov.
|
kentcdodds
reviewed
Jun 15, 2020
|
@all-contributors please add @JoshuaKGoldberg for code and tests |
|
I've put up a pull request to add @JoshuaKGoldberg! 🎉 |
|
🎉 This PR is included in version 7.15.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Added a nice explicit error message for the case in #609 of a
Promiseor Promise-like passed to a function that expects a DOM node.Why:
Better error messages = happier users! 💝
How:
Per #609 (comment), checked if
node.then instanceof Function.Checklist:
docs site N/A
I'm not attached to this particular error message, if a reviewer can think of something better that'd be nice.