-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added explicit error message for null or undefined matchers #718
Added explicit error message for null or undefined matchers #718
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 35799ca:
|
Codecov Report
@@ Coverage Diff @@
## master #718 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 24
Lines ? 635
Branches ? 165
==========================================
Hits ? 635
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Just one suggested change
@all-contributors please add @JoshuaKGoldberg for code and tests |
I've put up a pull request to add @JoshuaKGoldberg! 🎉 |
🎉 This PR is included in version 7.21.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
Added a nice explicit error message for the case in #717 of
null
orundefined
as amatcher
.Why:
Better error messages = happier users! 💝
How:
Checklist:
docs site
As before: I'm not attached to this particular error message, if a reviewer can think of something better that'd be nice.