Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added Using Without Jest section #79

Merged

Conversation

dadamssg
Copy link
Contributor

What:
Added Using Without Jest docs section

Why:
There is setup required.

How:
Edited the readme

Checklist:

  • Documentation
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table

@dadamssg
Copy link
Contributor Author

dadamssg commented Jul 20, 2018

image

And further down

image

I was thinking that in the react-testing-library readme I could create a PR to add that "See Using Without Jest" link but link it to this new section in this repo so it's not just duplicated. Or I can just add it there as well. Whatever you think is best.

Let me know if the verbiage needs adjusting.

I discovered a package that can simplify this process greatly :)
@kentcdodds
Copy link
Member

Let me know what you think of my revisions! Please try it out and make sure it works 😅

@kentcdodds
Copy link
Member

Oh, and simply linking to this documentation from react-testing-library sounds fine to me.

@dadamssg
Copy link
Contributor Author

Looks good to me!

image

@kentcdodds kentcdodds merged commit 6a8312d into testing-library:master Jul 20, 2018
@kentcdodds
Copy link
Member

Thanks!

@kentcdodds
Copy link
Member

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

alexkrolick pushed a commit to alexkrolick/dom-testing-library that referenced this pull request Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants