Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to stop reporting user-event in no-await-sync-events #669

Closed
Belco90 opened this issue Oct 5, 2022 · 3 comments · Fixed by #803
Closed

Add option to stop reporting user-event in no-await-sync-events #669

Belco90 opened this issue Oct 5, 2022 · 3 comments · Fixed by #803
Assignees
Labels
enhancement New feature or request released v6 Next major v6

Comments

@Belco90
Copy link
Member

Belco90 commented Oct 5, 2022

no-await-sync-events must not report user-event methods by default since it aims user-event v14, so only fire-event it's reported. However, we need an option to decide which methods to be reported: fire-event, user-event or both.

The idea is to include an option in the same way as #626 with the following values for presets:

  • dom: rule enabled with fire-event
  • angular: rule enabled with fire-event
  • react: rule enabled with fire-event
  • vue: rule not enabled
  • marko: rule not enabled
@skovy
Copy link
Collaborator

skovy commented Oct 5, 2022

Does there need to be a user-event option at all, or is the idea to still support user-event versions before v14 on v6 of this package which means it would still be needed?

@Belco90
Copy link
Member Author

Belco90 commented Oct 5, 2022

The idea is to still support user-event versions before v14 on v6 of the plugin. We did the same for await-async-events so by default it reports user-event as async, but can be disabled to provide backward compatibility for user-event prior to v14. Same here, so by default it doesn't report user-event as sync, unless it's enabled through its options.

@github-actions
Copy link

🎉 This issue has been resolved in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released v6 Next major v6
Projects
None yet
2 participants