Contradicting issue reports between async-await-events and no-await-sync-events

[wadehammes]

Have you read the Troubleshooting section?

Yes

Plugin version

latest

ESLint version

latest

Node.js version

18.16.1

package manager and version

pnpm 8.6.12

Operating system

Macos 13.5

Bug description

I upgraded to v6 and was first met with this error in my Vercel build:

Easy enough. These had no await so I added that before each. Thinking I would be in the clear, I wasn't expecting the build to fail. However, I am now getting the opposite error in Vercel:

Unsure of what to do here or if this a bug or I need to do some combination of rules config in my eslint. Thanks for the help in advance!

Steps to reproduce

See above

Error output/screenshots

No response

ESLint configuration

No rules overridden in ESLint

Rule(s) affected

async-await-events and no-await-sync-events

Anything else?

No response

Do you want to submit a pull request to fix this bug?

No

[wadehammes]

I wonder if this relates to #669

[Belco90]

Hi @wadehammes, thanks for reporting.

Just to confirm, you are extending one of the provided presets without overriding any rule manually, right?

[wadehammes]

Hi @wadehammes, thanks for reporting.

Just to confirm, you are extending one of the provided presets without overriding any rule manually, right?

yes I am extending plugin:testing-library/react in my eslint plugins, no manually overridden rules

[tobiasklevenz]

seeing similar errors with 6.0.0 userEvent.click is not sync and actually does need await

[teobmg]

Same issue here - just extending no overriding

[Belco90]

I'll take care of this one next week (hopefully).

[github-actions]

🎉 This issue has been resolved in version 6.0.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[fabb]

@Belco90 i still see the issue of false await-async-events errors in 6.0.1.

I extend the plugin:testing-library/react preset and do not override any testing-library rules, and i checked the node_modules, the correct eslint-plugin-testing-library version is installed, and i don't use an eslint cache.

[Belco90]

@fabb can you create a new issue for it? So you can describe better the problem.

[fabb]

@Belco90 it's exactly the same problem as in the OP. but sure, i can create a new ticket if reopening is not possible.

[tay1orjones]

v6.0.1 fixed it for us, thanks!

[fabb]

Ok nvm, I thought we could remove async for react, but it's the other way around 🙈