fix(await-async-query): get correct Identifier related to CallExpression #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belco90
commented
May 9, 2021
| @@ -46,10 +48,16 @@ export default createTestingLibraryRule<Options, MessageIds>({ | |||
| } | |||
|
|
|||
| return { | |||
| 'CallExpression Identifier'(node: TSESTree.Identifier) { | |||
There was a problem hiding this comment.
The problem was here. This is getting an Identifier n levels within a CallExpression, which can lead to an Identifier not related at all to the CallExpression. Fixed just using getDeepestIdentifierNode so we get the Identifier of the CallExpression we are interested in.
timdeschryver
approved these changes
May 9, 2021
MichaelDeBoey
approved these changes
May 9, 2021
|
🎉 This PR is included in version 4.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #359