Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(semantic-release): change package root #797

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

Belco90
Copy link
Member

@Belco90 Belco90 commented Aug 9, 2023

Checks

Changes

  • Remove the pkgRoot from semantic-release config, so it points directly to the root of the repo instead of dist/ folder.

Context

Pointing to the root of the repo is the correct behavior. It was incorrect before, that's why we had to copy the extra files after building. By setting the pkgRoot to the root of the repo, and setting the proper files in the package.json, npm CLI and semantic-release will bundle and publish it as expected.

@Belco90 Belco90 requested a review from a team August 9, 2023 10:19
@Belco90 Belco90 self-assigned this Aug 9, 2023
@Belco90 Belco90 added the chore Changes that affect the build system, CI config or other changes that don't modify src/test files label Aug 9, 2023
@Belco90 Belco90 enabled auto-merge (squash) August 10, 2023 08:34
@Belco90 Belco90 merged commit 6b9c03e into main Aug 10, 2023
@Belco90 Belco90 deleted the rework-semantic-release-publishing branch August 10, 2023 08:41
@github-actions
Copy link

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that affect the build system, CI config or other changes that don't modify src/test files released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants