feat: update toBeInTheDOM #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
approved these changes
Jul 4, 2018
There was a problem hiding this comment.
This is awesome! I'm going to leave the actual code review to @gnapse as he's the specialist here, but I'm excited about the prospect of this update!
|
We've got some merge conflicts here, probably because I merged your last PR. Could you fix those up please? |
|
Can do, working on it now. :-)!
Thank you for merging!
|
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was referenced Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
In efforts to implement #3 : added .toContainElement and updated .toBeInTheDOM to allow containers.
Why:
The efforts were to implement the desired items from #3
How:
Added a to-contain-element.js functionality
Updated to-be-in-the-dom.js functionality to have an optional container.
Checklist:
After working on this, it might be easier to reason about the tests if they were in separate files.