-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup old website data #747
chore: cleanup old website data #747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the lockfiles to our .gitignore
? They should already be part of it if they're in the root directory.
@eps1lon done, also found another package-lock file at the root so I removed that also in this PR. |
Huh, now I'm confused. I thought we didn't have lockfiles. Let's just remove the yarn.lock and then rethink package managment later. I suspect we want to use npm workspaces. |
I think I pushed the package-lock file by accident a couple months ago, based on what I know we don't want to use lock files in the org. I can revert that change and just keep the package-lock if you think it will be best for now :) |
The "no lockfile policy" is applied to libraries. The docs are an app so a lockfile makes more sense. The main goal here is to avoid contributor confusion (yarn vs npm). If the npm lockfile causes problems or the contribution workflow needs work we can discuss these problems separately. |
506be48
to
ae96ecc
Compare
Got it, thanks for the explanation :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the confusion.
No description provided.