Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup old website data #747

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

MatanBobi
Copy link
Member

No description provided.

@MatanBobi MatanBobi requested a review from alexkrolick January 20, 2021 07:42
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the lockfiles to our .gitignore? They should already be part of it if they're in the root directory.

@MatanBobi
Copy link
Member Author

@eps1lon done, also found another package-lock file at the root so I removed that also in this PR.

@eps1lon
Copy link
Member

eps1lon commented Jan 20, 2021

Huh, now I'm confused. I thought we didn't have lockfiles. Let's just remove the yarn.lock and then rethink package managment later. I suspect we want to use npm workspaces.

@MatanBobi
Copy link
Member Author

Huh, now I'm confused. I thought we didn't have lockfiles. Let's just remove the yarn.lock and then rethink package managment later. I suspect we want to use npm workspaces.

I think I pushed the package-lock file by accident a couple months ago, based on what I know we don't want to use lock files in the org.

I can revert that change and just keep the package-lock if you think it will be best for now :)

@eps1lon
Copy link
Member

eps1lon commented Jan 20, 2021

The "no lockfile policy" is applied to libraries. The docs are an app so a lockfile makes more sense.

The main goal here is to avoid contributor confusion (yarn vs npm). If the npm lockfile causes problems or the contribution workflow needs work we can discuss these problems separately.

@MatanBobi MatanBobi force-pushed the chores/cleanup-i18n-yarn branch from 506be48 to ae96ecc Compare January 20, 2021 09:58
@MatanBobi
Copy link
Member Author

The "no lockfile policy" is applied to libraries. The docs are an app so a lockfile makes more sense.

The main goal here is to avoid contributor confusion (yarn vs npm). If the npm lockfile causes problems or the contribution workflow needs work we can discuss these problems separately.

Got it, thanks for the explanation :)
Reverted the package-lock removal and the .gitignore now only contains yarn.lock.

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion.

@eps1lon eps1lon merged commit 337eab9 into testing-library:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants