Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests #7

Closed
smeijer opened this issue May 23, 2020 · 8 comments
Closed

add tests #7

smeijer opened this issue May 23, 2020 · 8 comments
Labels

Comments

@smeijer
Copy link
Member

smeijer commented May 23, 2020

A testing-playground.com without tests... I don't think that should be a thing, but at this moment it is.

We should fix that, and use jest & testing-library to do it.

@smeijer smeijer added the chore label May 23, 2020
@marcosvega91
Copy link
Member

hey @smeijer have you any preference about folder structure, or configuration?

@smeijer
Copy link
Member Author

smeijer commented May 23, 2020

I usually place my tests next to the files they cover.

Like:

./src/components/Editor.js
./src/components/Editor.tests.js
./src/lib/parser.js
./src/lib/parser.tests.js

Test config files (if required), I usually place in ./test.

But I'm open to suggestions.

@marcosvega91
Copy link
Member

marcosvega91 commented May 23, 2020

I usually prefer to separate the things to be clearer but this is a good solution too :)
For now I think that there is no need for any particular configuration. If we need I used to create a folder test like you said

@JacobMGEvans
Copy link
Contributor

I don't mind making Unit Tests, I would like to try out Cypress using your project, if you are cool with that of course.

@marcosvega91
Copy link
Member

I think that the project need also E2E testing so I think could be ok.

@smeijer
Copy link
Member Author

smeijer commented May 24, 2020

@JacobMGEvans, go for it 👍 I believe it's great to have those tests.

@JacobMGEvans
Copy link
Contributor

Awesome! On it.

@smeijer
Copy link
Member Author

smeijer commented Jun 15, 2020

Closing this one. The test setup was added by #12, and the individual tests will be an ongoing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants