chore: add unit tests #32
Conversation
| import { getData } from './queryAdvise'; | ||
| import { renderIntoDocument } from '../../tests/utils/dom-render'; | ||
|
|
||
| describe('queryAdvise', () => { |
There was a problem hiding this comment.
No need for this describe, since the filename's already saying we're testing queryAdvise
| import { renderIntoDocument } from '../../tests/utils/dom-render'; | ||
|
|
||
| describe('queryAdvise', () => { | ||
| describe('getData', () => { |
There was a problem hiding this comment.
We should also make this file more flat
https://kentcdodds.com/blog/avoid-nesting-when-youre-testing
| <input placeholder="I'm a placeholder" /> | ||
| </div>`); | ||
| }; | ||
| describe('parser', () => { |
There was a problem hiding this comment.
No need for this describe, since the filename's already saying we're testing parser
| htmlRoot: container, | ||
| js: 'screen.getByText("I\'m a label")', | ||
| }); | ||
| expect(result).toMatchSnapshot(); |
There was a problem hiding this comment.
I think using inline snapshots would be better instead
src/lib/ensureArray.test.js
Outdated
| @@ -0,0 +1,13 @@ | |||
| import { ensureArray } from './ensureArray'; | |||
|
|
|||
| describe('ensureArray', () => { | |||
There was a problem hiding this comment.
No need for this describe, since the filename's already saying we're testing ensureArray
There was a problem hiding this comment.
Agree. We can build tests without describe and using test instead of it. Looks cleaner.
| @@ -0,0 +1,57 @@ | |||
| import state from './state'; | |||
|
|
|||
| describe('state', () => { | |||
There was a problem hiding this comment.
No need for this describe, since the filename's already saying we're testing state
| import state from './state'; | ||
|
|
||
| describe('state', () => { | ||
| describe('updateTitle', () => { |
There was a problem hiding this comment.
We should also make this file more flat
https://kentcdodds.com/blog/avoid-nesting-when-youre-testing
|
I'm closing this because is very expensive now test everything. I think is better to add test on every PR |
Following up #7 I have started to test the application. I only a draft for now.