-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Get file extension from file path and changes use of reserved word 'format' to 'fmt' #30
Conversation
…rd 'format' to 'fmt'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some renames for more clarity
I've implemented the changes requested |
70fb0c9
to
74ee62e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ruff ci is still breaking, just run 'task format' to fix :)
Give a look at the tests too
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
7142e8a
to
abdc33a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for the contribution :)
I've run the following test code:
It saved ss.png in the root directory, as expected, but when i tried to open it with the ubuntu's default image visualizer, i got the following error:
When i tried to change it to jpeg, it worked just fine, so i've implemented some logic to get the file extension from the file path given by the developer, i've also changed the use of the reserved word "format" to "fmt" to avoid problems.